Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System-CVE pair status not being set correctly #1926

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

leSamo
Copy link
Member

@leSamo leSamo commented Jul 26, 2023

https://issues.redhat.com/browse/VULN-2637

During some refactoring of selected items, the names of some parameters got changed which caused multiple issues while editing the status on the CVE detail page:

  1. If you try to edit status, don't open the status select and click "Save", you'd get an error
  2. If you selected an item which already has status/justification set, the form field did not get prefilled.

@leSamo leSamo requested a review from a team as a code owner July 26, 2023 16:13
@jira-linking
Copy link

jira-linking bot commented Jul 26, 2023

Commits missing Jira IDs:
6492dfe
2b12f04

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (4c2b953) 71.58% compared to head (2b12f04) 71.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1926      +/-   ##
==========================================
- Coverage   71.58%   71.57%   -0.01%     
==========================================
  Files         117      117              
  Lines        2939     2938       -1     
  Branches      882      882              
==========================================
- Hits         2104     2103       -1     
  Misses        835      835              
Files Changed Coverage Δ
...nents/SmartComponents/Modals/CvePairStatusModal.js 98.85% <100.00%> (ø)
...omponents/SmartComponents/SystemCves/SystemCves.js 83.90% <100.00%> (-0.19%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AsToNlele AsToNlele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@leSamo leSamo merged commit 18d7803 into RedHatInsights:master Aug 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants